Robert Kanter commented on OOZIE-2657:

[~jaydeepvishwakarma], [~abhishekbafna]
I'm not sure this is a good idea.  It's going to make backporting patches (e.g. 
Cloudera, Yahoo!, Hortonworks, etc) harder because it makes a lot of changes to 
a lot of files (the same reason we don't do a mass cleanup of imports).  IMO, 
that would be better left to fixing when we make other changes to those files.  
I'm also not sure there's any real benefit to removing the redundant modifiers? 
 In fact, isn't it more clear with them?

> Clean up redundant access modifiers from oozie interfaces
> ---------------------------------------------------------
>                 Key: OOZIE-2657
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2657
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Abhishek Bafna
>            Assignee: Abhishek Bafna
>            Priority: Minor
>              Labels: code-cleanup
>             Fix For: 4.3.0
>         Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
> By default java {{interface}} fields are {{public static final}}. Some of the 
> Oozie interface still explicitly declare these redundant access modifier. I 
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant 
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
>     public static final String VERSIONS = "versions";
>     public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
>     public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for 
> V0 only
>     public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}

This message was sent by Atlassian JIRA

Reply via email to