Jaydeep Vishwakarma commented on OOZIE-2657:

The changes are in {{interface}} and it does not change so frequently, except 
the {{interface}} with contains only {{constants}}. 
Also I believe removing redundant access modifier will make any backward 
compatibility issue, perhaps you meant something else?
It is common knowledge in case of interface that everything is public (there is 
no point in putting a private member, because you are actually establishing an 
interface) and and all assignments are final, because no instance it is also at 
class level. Java's native supplied JDK interfaces don't put these modifiers. 
So if you want to follow best practices, that is what you would follow.

> Clean up redundant access modifiers from oozie interfaces
> ---------------------------------------------------------
>                 Key: OOZIE-2657
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2657
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>            Reporter: Abhishek Bafna
>            Assignee: Abhishek Bafna
>            Priority: Minor
>              Labels: code-cleanup
>             Fix For: 4.3.0
>         Attachments: OOZIE-2657-00-amend.patch, OOZIE-2657-00.patch
> By default java {{interface}} fields are {{public static final}}. Some of the 
> Oozie interface still explicitly declare these redundant access modifier. I 
> think we can clean it.
> Similarly, methods declared in the interface are {{public}}. This redundant 
> declaration can be cleaned up.
> {code}
> public interface RestConstants {
>     public static final String VERSIONS = "versions";
>     public static final String JOB = "job";
> ...
> }
> public interface JsonTags {
>     public static final String OOZIE_SAFE_MODE = "safeMode"; //Applicable for 
> V0 only
>     public static final String OOZIE_SYSTEM_MODE = "systemMode";
> ...
> }
> {code}

This message was sent by Atlassian JIRA

Reply via email to