[
https://issues.apache.org/jira/browse/OOZIE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15534292#comment-15534292
]
Robert Kanter commented on OOZIE-1986:
--------------------------------------
This is great. I like that someone already wrote a diff tool for this that we
can just use :)
A couple quick things:
# Can you post the patch on ReviewBoard? It will be easier to comment on
specific things that way given that this is a shell script.
# We should make the output show up in the report (i.e. the Hadoop QA comment
above me), and link to the diff
# Run the script through ShellCheck. It's kind of like findbugs, but for shell
scripts. It'll suggest a bunch of things to fix. You can find it
[here|https://www.shellcheck.net/]; it's also available in package managers to
easily install locally.
> Add findbugs report to pre-commit build
> ---------------------------------------
>
> Key: OOZIE-1986
> URL: https://issues.apache.org/jira/browse/OOZIE-1986
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Fix For: 4.3.0
>
> Attachments: OOZIE-1986.001.patch
>
>
> Now that we have OOZIE-1793, it will be really useful to have the pre-commit
> build generate a findbugs report. It should probably before and after the
> patch and only complain it there are more after. And it should link to the
> report. Ideally, this would do some kind of diff (like Hadoop does) so it's
> easy to identify the new findbugs items.
> You can generate the findbugs reports by running:
> {noformat}
> mvn verify -DskipTests
> {noformat}
> This also runs checkstyle
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
