[ 
https://issues.apache.org/jira/browse/OOZIE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548673#comment-15548673
 ] 

Andras Piros commented on OOZIE-1986:
-------------------------------------

The last issue remaining here is that in the bash scripts some lines are too 
long.

This patchset puts also the bash scripts to the raw patch analysis blacklist, 
as in general, bash lines are quite cumbersome to cut to a given length - let 
alone these contain long strings.

> Add FindBugs report to pre-commit build
> ---------------------------------------
>
>                 Key: OOZIE-1986
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1986
>             Project: Oozie
>          Issue Type: Bug
>          Components: tests
>            Reporter: Robert Kanter
>            Assignee: Andras Piros
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-1986.001.patch, OOZIE-1986.002.patch, 
> OOZIE-1986.003.patch
>
>
> Now that we have OOZIE-1793, it will be really useful to have the pre-commit 
> build generate a findbugs report.  It should probably before and after the 
> patch and only complain it there are more after.  And it should link to the 
> report.  Ideally, this would do some kind of diff (like Hadoop does) so it's 
> easy to identify the new findbugs items.
> You can generate the findbugs reports by running:
> {noformat}
> mvn verify -DskipTests
> {noformat}
> This also runs checkstyle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to