[
https://issues.apache.org/jira/browse/OOZIE-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15536355#comment-15536355
]
Andras Piros commented on OOZIE-1986:
-------------------------------------
Hi Robert,
thanks for your feedback!
My thoughts:
* Good idea, just did it :)
* The output will be shown in the report later on (when this new {{.sh}} file
will also run) and there will be diffs generated like
{{core/findbugs-new.html}} but I cannot tell how to make that filenames inside
the reports clickable since I cannot tell the real path of the generated file
inside JIRA. But these will also appear in the generated folder of the Jenkins
job
* Nice catch on {{shellcheck}}, using it. The actual patchset doesn't have any
warnings anymore with this marvellous tool
> Add FindBugs report to pre-commit build
> ---------------------------------------
>
> Key: OOZIE-1986
> URL: https://issues.apache.org/jira/browse/OOZIE-1986
> Project: Oozie
> Issue Type: Bug
> Components: tests
> Reporter: Robert Kanter
> Assignee: Andras Piros
> Fix For: 4.3.0
>
> Attachments: OOZIE-1986.001.patch, OOZIE-1986.002.patch
>
>
> Now that we have OOZIE-1793, it will be really useful to have the pre-commit
> build generate a findbugs report. It should probably before and after the
> patch and only complain it there are more after. And it should link to the
> report. Ideally, this would do some kind of diff (like Hadoop does) so it's
> easy to identify the new findbugs items.
> You can generate the findbugs reports by running:
> {noformat}
> mvn verify -DskipTests
> {noformat}
> This also runs checkstyle
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
