[ 
https://issues.apache.org/jira/browse/OOZIE-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15753541#comment-15753541
 ] 

Abhishek Bafna commented on OOZIE-2751:
---------------------------------------

Thank you [~andras.piros] for your feedback and suggestion.

Though we are still casting the {{BaseEngine}} instance individually for each 
type (wf, coord and bundle) and operation (kill, suspend, resume). I believe, 
it will be good to use design pattern for the same. I will keep your 
suggestions in the next patch with little modification. I will add the required 
testcases and upload the patch for review. Thanks.

> LocalOozieClient is missing methods from OozieClient
> ----------------------------------------------------
>
>                 Key: OOZIE-2751
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2751
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Abhishek Bafna
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-2751-00.patch, OOZIE-2751-01.patch, 
> OOZIE-2751-02.patch, OOZIE-2751-03.patch
>
>
> {{LocalOozieClient}} works by wrapping direct calls to {{DagEngine}} in the 
> normal {{OozieClient}} methods instead of making REST calls to an Oozie 
> Server.  However, it currently doesn't override all methods, which means you 
> hit the {{OozieClient}} implementation, which tries to make a REST call and 
> will fail (because it's not setup for that).  For example, {{getStatus(String 
> jobId)}} isn't overridden, and doesn't work when used from 
> {{LocalOozieClient}}.
> We should also create a test that verifies that all methods are overridden.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to