[
https://issues.apache.org/jira/browse/OOZIE-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754845#comment-15754845
]
Andras Piros commented on OOZIE-2751:
-------------------------------------
[~abhishekbafna] yw :) We are still casting because we didn't want to touch
existing operation etc. classes. I've looked into usages and we'd have to
refactor quite many places if we did so.
Nevertheless, using double dispatch w/ Visitor pattern - that makes code more
readable.
Thanks for the patches!
+1 (non-binding)
> LocalOozieClient is missing methods from OozieClient
> ----------------------------------------------------
>
> Key: OOZIE-2751
> URL: https://issues.apache.org/jira/browse/OOZIE-2751
> Project: Oozie
> Issue Type: Bug
> Reporter: Robert Kanter
> Assignee: Abhishek Bafna
> Fix For: 5.0.0
>
> Attachments: OOZIE-2751-00.patch, OOZIE-2751-01.patch,
> OOZIE-2751-02.patch, OOZIE-2751-03.patch, OOZIE-2751-04.patch
>
>
> {{LocalOozieClient}} works by wrapping direct calls to {{DagEngine}} in the
> normal {{OozieClient}} methods instead of making REST calls to an Oozie
> Server. However, it currently doesn't override all methods, which means you
> hit the {{OozieClient}} implementation, which tries to make a REST call and
> will fail (because it's not setup for that). For example, {{getStatus(String
> jobId)}} isn't overridden, and doesn't work when used from
> {{LocalOozieClient}}.
> We should also create a test that verifies that all methods are overridden.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
