[ 
https://issues.apache.org/jira/browse/OOZIE-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796247#comment-15796247
 ] 

Robert Kanter commented on OOZIE-2751:
--------------------------------------

It's unfortunate that the {{bulkModifyJobs}} methods return with {{JSONObject}} 
instead of things like {{WorkflowJob}} or whatever, but I guess we can't do 
anything about that :(

I would like if we added a test that would ensure that we don't have any public 
methods in {{OozieCLient}} that are not overridden in the local subclasses.  
(i.e. using reflection magic)  This will prevent this sort of problem in the 
future.

> LocalOozieClient is missing methods from OozieClient
> ----------------------------------------------------
>
>                 Key: OOZIE-2751
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2751
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Robert Kanter
>            Assignee: Abhishek Bafna
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-2751-00.patch, OOZIE-2751-01.patch, 
> OOZIE-2751-02.patch, OOZIE-2751-03.patch, OOZIE-2751-04.patch
>
>
> {{LocalOozieClient}} works by wrapping direct calls to {{DagEngine}} in the 
> normal {{OozieClient}} methods instead of making REST calls to an Oozie 
> Server.  However, it currently doesn't override all methods, which means you 
> hit the {{OozieClient}} implementation, which tries to make a REST call and 
> will fail (because it's not setup for that).  For example, {{getStatus(String 
> jobId)}} isn't overridden, and doesn't work when used from 
> {{LocalOozieClient}}.
> We should also create a test that verifies that all methods are overridden.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to