> On okt. 27, 2017, 1:47 du, András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 154-155 (patched) > > <https://reviews.apache.org/r/63327/diff/1/?file=1869513#file1869513line154> > > > > Should go to `LauncherAM#OOZIE_LAUNCHER_MODIFY_ACL`.
Initially I wanted to put them there. However, these variables are not referenced in LauncherAM, because you set up the ACLs in JavaActionExecutor. > On okt. 27, 2017, 1:47 du, András Piros wrote: > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > > Lines 1659-1687 (patched) > > <https://reviews.apache.org/r/63327/diff/1/?file=1869516#file1869516line1659> > > > > In general, that's a good negative test. What about a positive one - > > killing succeeds w/ the given user? What about another one when > > `mapreduce.cluster.acls.enabled` is left `false` (the feature shouldn't > > work)? I will add those scenarios as well. > On okt. 27, 2017, 1:47 du, András Piros wrote: > > core/src/test/java/org/apache/oozie/test/XTestCase.java > > Lines 1031-1032 (patched) > > <https://reviews.apache.org/r/63327/diff/1/?file=1869518#file1869518line1031> > > > > That's something I'd set per test case. I don't think we should in > > general override the default value for all the `? extends XTestCase`s. This is theoretically possible. But it would mean that we have to stop the Mini YARN cluster for this test and then restart it for the rest of the test suite. I feel this could introduce some unwanted side-effects. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63327/#review189427 ----------------------------------------------------------- On okt. 26, 2017, 12:24 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63327/ > ----------------------------------------------------------- > > (Updated okt. 26, 2017, 12:24 du) > > > Review request for oozie, András Piros, Attila Sasvari, Peter Cseh, and > Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2897 > > > Diffs > ----- > > client/src/main/resources/oozie-common-1.0.xsd ddae91224 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 76d0daa4f > > core/src/main/java/org/apache/oozie/workflow/lite/LauncherConfigHandler.java > c36774239 > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 43c71b0ad > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > a7bd357f8 > core/src/test/java/org/apache/oozie/service/TestSchemaService.java > 940868aeb > core/src/test/java/org/apache/oozie/test/XTestCase.java 584aa12ef > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a361078ac > core/src/test/resources/fair-scheduler-alloc.xml PRE-CREATION > core/src/test/resources/wf-schema-global-launcherconf.xml 9cd4f6c37 > > > Diff: https://reviews.apache.org/r/63327/diff/1/ > > > Testing > ------- > > - Unit test added > - Verified on a 4-node cluster > > > Thanks, > > Peter Bacsko > >
