----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63327/#review189721 -----------------------------------------------------------
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java Lines 1659 (patched) <https://reviews.apache.org/r/63327/#comment266940> This comment is not correct. We use "test2" and not "oozie". Will fix this. core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java Lines 1673 (patched) <https://reviews.apache.org/r/63327/#comment266941> This is not correct either... Actually we do submit as "test", but the queue admin is the current user, not "test". Will fix this too. core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java Lines 2564-2572 (original), 2596-2598 (patched) <https://reviews.apache.org/r/63327/#comment266942> I changed this because switching to Fair Scheduler changed the behaviour of this test. That is, it does not complain about a non-existing queue, therefore the application starts to run. - Peter Bacsko On okt. 31, 2017, 3:02 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63327/ > ----------------------------------------------------------- > > (Updated okt. 31, 2017, 3:02 du) > > > Review request for oozie, András Piros, Attila Sasvari, Peter Cseh, and > Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2897 > > > Diffs > ----- > > client/src/main/resources/oozie-common-1.0.xsd ddae91224 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 6a25e5c89 > core/src/main/java/org/apache/oozie/action/hadoop/YarnACLHandler.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/workflow/lite/LauncherConfigHandler.java > c36774239 > core/src/main/resources/oozie-default.xml b2036997d > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 36b302667 > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 43c71b0ad > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > adb2168ca > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationInjector.java > 4c5b0f972 > core/src/test/java/org/apache/oozie/action/hadoop/TestYarnACLHandler.java > PRE-CREATION > core/src/test/java/org/apache/oozie/service/TestSchemaService.java > 940868aeb > core/src/test/java/org/apache/oozie/test/XTestCase.java 584aa12ef > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a361078ac > core/src/test/resources/fair-scheduler-alloc.xml PRE-CREATION > core/src/test/resources/wf-schema-global-launcherconf.xml 9cd4f6c37 > > > Diff: https://reviews.apache.org/r/63327/diff/2/ > > > Testing > ------- > > - Unit test added > - Verified on a 4-node cluster > > > Thanks, > > Peter Bacsko > >
