> On nov. 3, 2017, 10:33 de, András Piros wrote: > > core/src/test/java/org/apache/oozie/test/XTestCase.java > > Lines 1046-1047 (patched) > > <https://reviews.apache.org/r/63327/diff/2/?file=1873436#file1873436line1047> > > > > Depending on the runtime value of > > `yarn.resourcemanager.scheduler.class`, please set > > `yarn.scheduler.fair.allocation.file` to `fair-scheduler-alloc.xml` for > > `FairScheduler`, and please set another value and another XML configuration > > file for `CapacityScheduler`. > > > > As `CapacityScheduler` is the default one in upstream Hadoop, we > > shouldn't override `yarn.resourcemanager.scheduler.class` to > > `FairScheduler`.
I'll change the code based on your suggestion. There will be one difference: there will be no XML config for Capacity Scheduler, because it's hard-coded to look up capacity-scheduler.xml from the classpath. If there are multiple XMLs on the classpath with the same name, we don't know which one will be loaded. I think it's really silly, but that's how it works right now. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63327/#review190021 ----------------------------------------------------------- On okt. 31, 2017, 3:02 du, Peter Bacsko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63327/ > ----------------------------------------------------------- > > (Updated okt. 31, 2017, 3:02 du) > > > Review request for oozie, András Piros, Attila Sasvari, Peter Cseh, and > Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2897 > > > Diffs > ----- > > client/src/main/resources/oozie-common-1.0.xsd ddae91224 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 6a25e5c89 > core/src/main/java/org/apache/oozie/action/hadoop/YarnACLHandler.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/workflow/lite/LauncherConfigHandler.java > c36774239 > core/src/main/resources/oozie-default.xml b2036997d > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > 36b302667 > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 43c71b0ad > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > adb2168ca > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherConfigurationInjector.java > 4c5b0f972 > core/src/test/java/org/apache/oozie/action/hadoop/TestYarnACLHandler.java > PRE-CREATION > core/src/test/java/org/apache/oozie/service/TestSchemaService.java > 940868aeb > core/src/test/java/org/apache/oozie/test/XTestCase.java 584aa12ef > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a361078ac > core/src/test/resources/fair-scheduler-alloc.xml PRE-CREATION > core/src/test/resources/wf-schema-global-launcherconf.xml 9cd4f6c37 > > > Diff: https://reviews.apache.org/r/63327/diff/2/ > > > Testing > ------- > > - Unit test added > - Verified on a 4-node cluster > > > Thanks, > > Peter Bacsko > >
