> On Feb. 25, 2019, 10:04 a.m., Andras Salamon wrote: > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > > Lines 398 (patched) > > <https://reviews.apache.org/r/70042/diff/1/?file=2126418#file2126418line398> > > > > There are two ways to specify the files: > > > > --files xxxx > > --files=xxxx > > > > Could you please also test the second type. > > Denes Bodo wrote: > I think for this 4 cases creating parametrized tests does not worth.
I agreee. That would be overkill. > On Feb. 25, 2019, 10:04 a.m., Andras Salamon wrote: > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > > Lines 410-414 (patched) > > <https://reviews.apache.org/r/70042/diff/1/?file=2126418#file2126418line410> > > > > I think it would be possible to create better assertions here without > > converting the List<String> to String. > > > > Could you please also add assert messages. > > Denes Bodo wrote: > In an array list I cannot see a better check. Any idea is welcome. Your assertForFilePaths solution looks good to me. - Andras ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70042/#review213151 ----------------------------------------------------------- On Feb. 26, 2019, 3:41 p.m., Denes Bodo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70042/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2019, 3:41 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3440 > https://issues.apache.org/jira/browse/OOZIE-3440 > > > Repository: oozie-git > > > Description > ------- > > Failing Oozie Launcher, Main class > [org.apache.oozie.action.hadoop.SparkMain], main() threw exception, File > file:/etc/spark2/conf/hive-site.xml%23hive-site.xml does not exist > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 28d9c5cc4 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 7ccd26ad5 > > > Diff: https://reviews.apache.org/r/70042/diff/3/ > > > Testing > ------- > > Unit tests run > > > Thanks, > > Denes Bodo > >
