[
https://issues.apache.org/jira/browse/OOZIE-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785778#comment-16785778
]
Hadoop QA commented on OOZIE-3446:
----------------------------------
Testing JIRA OOZIE-3446
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any star imports
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} Javadoc generation succeeded with the patch
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [22] new bugs found below threshold in total
that must be fixed.
. {color:green}+1{color} There are no new bugs found in
[fluent-job/fluent-job-api].
. {color:red}-1{color} There are [15] new bugs found below threshold in
[tools] that must be fixed, listing only the first [5] ones.
. You can find the SpotBugs diff here (look for the red and orange ones):
tools/findbugs-new.html
. The top [5] most important SpotBugs errors are:
. At OozieDBCLI.java:[line 578]: This use of
java/sql/Statement.executeUpdate(Ljava/lang/String;)I can be vulnerable to SQL
injection
. At OozieDBCLI.java:[line 568]: At OozieDBCLI.java:[line 567]
. At OozieDBCLI.java:[line 571]: At OozieDBCLI.java:[line 569]
. At OozieDBCLI.java:[line 573]: At OozieDBCLI.java:[line 572]
. At OozieDBCLI.java:[line 578]: At OozieDBCLI.java:[line 575]
. {color:red}-1{color} There are [1] new bugs found below threshold in
[sharelib/oozie] that must be fixed.
. You can find the SpotBugs diff here (look for the red and orange ones):
sharelib/oozie/findbugs-new.html
. The most important SpotBugs errors are:
. At ShellMain.java:[line 92]: This usage of
java/lang/ProcessBuilder.<init>(Ljava/util/List;)V can be vulnerable to
Command Injection
. At ShellMain.java:[line 90]: At ShellMain.java:[line 89]
. At ShellMain.java:[line 91]
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/git].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:red}-1{color} There are [6] new bugs found below threshold in
[core] that must be fixed, listing only the first [5] ones.
. You can find the SpotBugs diff here (look for the red and orange ones):
core/findbugs-new.html
. The top [5] most important SpotBugs errors are:
. At BulkJPAExecutor.java:[line 207]: This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection
. At BulkJPAExecutor.java:[line 177]: At BulkJPAExecutor.java:[line 176]
. At BulkJPAExecutor.java:[line 206]: At BulkJPAExecutor.java:[line 200]
. This use of
javax/persistence/EntityManager.createQuery(Ljava/lang/String;)Ljavax/persistence/Query;
can be vulnerable to SQL/JPQL injection: At BulkJPAExecutor.java:[line 207]
. At BulkJPAExecutor.java:[line 112]: At BulkJPAExecutor.java:[line 128]
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [webapp].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 3145
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/PreCommit-OOZIE-Build/1035/
> Migrate from commons-lang 2.x to commons-lang 3.x
> -------------------------------------------------
>
> Key: OOZIE-3446
> URL: https://issues.apache.org/jira/browse/OOZIE-3446
> Project: Oozie
> Issue Type: Improvement
> Affects Versions: trunk
> Reporter: Andras Salamon
> Assignee: duan xiong
> Priority: Major
> Attachments: OOZIE-3446-001.patch
>
>
> Currently Oozie uses both commons-lang 2.x ({{2.4}}) and 3.x ({{3.3.2}}).
> Versions {{2.4}} was released in 2008, {{2.6}} (latest 2.x) was released in
> 2011.
> Although it is possible to use both versions at the same time I think it's
> time to migrate from the legacy 2.x line and use only 3.x (at least directly).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
