Jon,
successfully added openejb-674-19.diff at revision 658955. I decided to
not add the IntelliJ support for now. Hope that's okay...
I really like the commons idea. We could for example provide an Ant task
or Maven extension that is executing the EJB annotation stuff.
Cheers
Daniel
Jonathan Gallimore wrote:
Hi,
I've attached openejb-674-19.diff and openejb-674-19-with-idea.diff to
Jira OPENEJB-674 (the latter is just shows the Idea plugin I created, as
discussed below. I'm not sure it should be checked in).
Cheers
Jon
Jonathan Gallimore wrote:
Daniel S. Haischt wrote:
I've done some refactoring to create a plugins-common module, and
also made a start on an IDEA plugin. I did however (after getting a
basic plugin working) discover that IDEA 7 already has a feature to
generate EJB3 annotations (its on the right click menu on the XML
editor when ejb-jar.xml is open) - I'm sure you can imagine my
disappointment!
Sigh... !
We could try to figure out whether Netbeans does not have support to
generate EJB3 annotations. That way your efforts would still be of use
for people not using eclipse.
I think that's a good idea. We also always intended to produce a
command line version which just outputted what needed to be done, so
the refactoring to a common module is definitely worthwhile.
Is the IntelliJ annotation support exactly doing what your code does?
Or would there be room for improvement?
I'd say the IDEA plugin is at least as good as (and probably better
than) my efforts. I'll separate the IDEA stuff I've done into a
separate patch and submit it, and you can try it and judge for
yourself ;-)
Cheers,
Jon
