rmannibucau commented on a change in pull request #92:
URL: https://github.com/apache/openjpa/pull/92#discussion_r771299987



##########
File path: openjpa-all/pom.xml
##########
@@ -110,6 +110,7 @@
                                         <Specification-Title>JSR-338 Java 
Persistence</Specification-Title>
                                         <Specification-Vendor>ORACLE, 
Inc.</Specification-Vendor>
                                         
<Specification-Version>2.2</Specification-Version>
+                                        
<Automatic-Module-Name>org.apache.openjpa.all</Automatic-Module-Name>

Review comment:
       isnt it a broken pattern to not have the same name for standard dep and 
bundle one? should be replaceable and it is no more?
   
   Maybe leave the bundle away from JPMS or only enable JPMS for it but not 
both, wdyt?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@openjpa.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to