solomax commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3781699082
##########
openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/simple/TestJava8TimeTypes.java:
##########
@@ -255,12 +265,70 @@ public void testGetCurrentLocalDateTime() {
}
public void testGetCurrentLocalTime() {
+ DBDictionary dict = getDbDictionary(emf);
+ if (dict instanceof OracleDictionary) {
+ // Oracle has no TIME data type
+ return;
+ }
+
EntityManager em = emf.createEntityManager();
- final TypedQuery<Java8TimeTypes> qry
- = em.createQuery("select j from Java8TimeTypes AS j where
j.localTimeField < LOCAL TIME", Java8TimeTypes.class);
+ final TypedQuery<Java8TimeTypes> qry = em.createQuery(
+ "select j from Java8TimeTypes AS j where j.localTimeField < LOCAL
TIME OR j.localTimeField >= LOCAL TIME", Java8TimeTypes.class);
Review Comment:
Hello @rmannibucau,
due to nature of local time it is hard to write condition which will pass :((
the test occasionally fails all the time
I can try to set something like `00:00` and hope test execution will not
happen on midnight
Would it be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
