rmannibucau commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3781914780
##########
pom.xml:
##########
@@ -1633,24 +1609,41 @@
<groupId>io.fabric8</groupId>
<artifactId>docker-maven-plugin</artifactId>
<configuration>
+ <keepContainer>false</keepContainer>
+ <removeVolumes>true</removeVolumes>
<images>
<image>
-
<!--<name>oracledb19c/oracle.19.3.0-ee:oracle19.3.0-ee</name>-->
-
<name>oracleinanutshell/oracle-xe-11g</name>
-
<!--<name>pvargacl/oracle-xe-18.4.0:latest</name>-->
+
<name>container-registry.oracle.com/database/express:${oracle.server.version}</name>
<run>
+ <env>
+
<ORACLE_PWD>${openjpa.oracle.password}</ORACLE_PWD>
+ </env>
<volumes>
<bind>
-
<volume>${project.basedir}/src/test/sql/oracle-docker:/docker-entrypoint-initdb.d/</volume>
+
<volume>${project.basedir}/src/test/sql/oracle-docker:/docker-entrypoint-initdb.d/setup/</volume>
+ <!-- NOTE this folder MUST
exist and have correct permissions!!!! -->
+
<volume>${project.basedir}/../jdbc_oradata:/opt/oracle/oradata</volume>
Review Comment:
adding it to .gitignore should be read by rat and ignored, it is also
possible to force uid/gid when running the container so it is not root but the
same as your host.
that said cleaner would be to create any local dir and just use the
container ephemeral space for that need no? init can be done with sh,
potentially running some java, was it tried?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
