solomax commented on code in PR #144:
URL: https://github.com/apache/openjpa/pull/144#discussion_r3781884372


##########
pom.xml:
##########
@@ -1633,24 +1609,41 @@
                         <groupId>io.fabric8</groupId>
                         <artifactId>docker-maven-plugin</artifactId>
                         <configuration>
+                            <keepContainer>false</keepContainer>
+                            <removeVolumes>true</removeVolumes>
                             <images>
                                 <image>
-                                    
<!--<name>oracledb19c/oracle.19.3.0-ee:oracle19.3.0-ee</name>-->
-                                    
<name>oracleinanutshell/oracle-xe-11g</name>
-                                    
<!--<name>pvargacl/oracle-xe-18.4.0:latest</name>-->
+                                    
<name>container-registry.oracle.com/database/express:${oracle.server.version}</name>
                                     <run>
+                                        <env>
+                                            
<ORACLE_PWD>${openjpa.oracle.password}</ORACLE_PWD>
+                                        </env>
                                         <volumes>
                                             <bind>
-                                                
<volume>${project.basedir}/src/test/sql/oracle-docker:/docker-entrypoint-initdb.d/</volume>
+                                                
<volume>${project.basedir}/src/test/sql/oracle-docker:/docker-entrypoint-initdb.d/setup/</volume>
+                                                <!-- NOTE this folder MUST 
exist and have correct permissions!!!! -->
+                                                
<volume>${project.basedir}/../jdbc_oradata:/opt/oracle/oradata</volume>
                                             </bind>
                                         </volumes>
                                         <ports>
                                             
<port>${docker.external.oracle.port}:1521</port>
+                                            <port>5500:5500</port>
                                         </ports>
+                                        <wait>
+                                            <log>DATABASE IS READY TO USE</log>
+                                            <time>3600000</time>
+                                        </wait>
                                     </run>
                                 </image>
                             </images>
                         </configuration>
+                        <dependencies>

Review Comment:
   I'm getting
   
   ```
   Exception in thread "Thread-2" java.lang.NoClassDefFoundError: 
com/google/common/io/ByteStreams$LimitedInputStream
        at 
io.fabric8.maven.docker.access.log.LogRequestor.readFully(LogRequestor.java:128)
        at 
io.fabric8.maven.docker.access.log.LogRequestor.readStreamFrame(LogRequestor.java:144)
        at 
io.fabric8.maven.docker.access.log.LogRequestor.parseResponse(LogRequestor.java:187)
        at 
io.fabric8.maven.docker.access.log.LogRequestor.run(LogRequestor.java:104)
   Caused by: java.lang.ClassNotFoundException: 
com.google.common.io.ByteStreams$LimitedInputStream
        at 
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
        at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:211)
        at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:202)
        at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:198)
        ... 4 more
   ```
   
   And tried to fix it
   Will drop



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to