rzo1 commented on PR #7:
URL: https://github.com/apache/openjpa-site/pull/7#issuecomment-6562645094

   Thanks, a few suggestions from my side:
   
   1. The link to https://www.apache.org/events/current-event is gone, only the 
apachecon `snippet.js` is left. The ASF site checker looks for the link in the 
HTML, so I would keep it next to the snippet.
   2. I crawled the preview: there are 49 broken internal links, but the live 
site has the same ones (old JPA 2.0 pages in `site-index.md`, the Eclipse 
screenshots in `testing.md`, ...). Not caused by this PR, but maybe a good time 
to drop them.
   3. Not from this PR, but on the downloads page: 4.1.0, 4.0.0 and 3.1.2 link 
to `closer.lua`, but they are no longer on downloads.apache.org, so these links 
are dead and should point to archive.apache.org. 2.2.2 and 2.4.3 are still on 
dist and could be archived. The verify section still talks about MD5 tools.
   4. Also not from this PR: the nightly manual links to `../../apidocs/`, 
which is not uploaded to nightlies, so the API links in 
https://nightlies.apache.org/openjpa/builds/latest/html/manual.html give 404.
   
   Otherwise looks good to me.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to