[GitHub] [openmeetings] sebawagner commented on a change in pull request #71: OPENMEETINGS-2315 Only StreamProcessor to hold reference of KStream

[GitBox]

sebawagner commented on a change in pull request #71:
URL: https://github.com/apache/openmeetings/pull/71#discussion_r417626809



##########
File path: 
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
##########
@@ -270,11 +260,10 @@ public void stopSharing() {
                }
        }
 
-       public void close(final StreamProcessor processor) {
-               for (final KStream stream : streams.values()) {
-                       stream.release(processor);
-               }
-               streams.clear();

Review comment:
       We don't need to clear here anymore. Cause it would lead to circular 
reference.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org