[GitHub] [openmeetings] sebawagner commented on a change in pull request #71: OPENMEETINGS-2315 Only StreamProcessor to hold reference of KStream

[GitBox]

sebawagner commented on a change in pull request #71:
URL: https://github.com/apache/openmeetings/pull/71#discussion_r418260423



##########
File path: 
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KRoom.java
##########
@@ -98,16 +103,16 @@ public RecordingChunkDao getChunkDao() {
        public KStream join(final StreamDesc sd) {
                log.info("ROOM {}: join client {}, stream: {}", roomId, 
sd.getClient(), sd.getUid());
                final KStream stream = new KStream(sd, this);
-               streams.put(stream.getUid(), stream);
+               streamProcessor.addStream(stream);
                return stream;
        }
 
        public Collection<KStream> getParticipants() {
-               return streams.values();
+               return streamProcessor.getStreamsByRoom(this.getRoomId());
        }
 
        public void onStopBroadcast(KStream stream, final StreamProcessor 
processor) {
-               streams.remove(stream.getUid());
+               streamProcessor.release(stream);

Review comment:
       I moved 
   `stream.release(processor);`
   that into StreamProcessor:: release()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org