[GitHub] [openmeetings] sebawagner commented on a change in pull request #71: OPENMEETINGS-2315 Only StreamProcessor to hold reference of KStream

[GitBox]

sebawagner commented on a change in pull request #71:
URL: https://github.com/apache/openmeetings/pull/71#discussion_r417627964



##########
File path: 
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
##########
@@ -144,7 +144,6 @@ public KStream startBroadcast(final StreamProcessor 
processor, final StreamDesc
                        }
                });
                outgoingMedia.addMediaFlowInStateChangeListener(evt -> 
log.warn("Media FlowIn :: {}", evt));
-               processor.addStream(this);

Review comment:
       We don't need to add stream here anymore, KStream is added in the 
constructor. So won't need to add it later on again.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org