sebawagner commented on a change in pull request #140:
URL: https://github.com/apache/openmeetings/pull/140#discussion_r601006511



##########
File path: 
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
##########
@@ -48,8 +49,15 @@ public void release() {
 
        public abstract void release(boolean remove);
 
-       public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline 
pipeline, Boolean recv) {
+       public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline 
pipeline, Boolean recv,
+                       String certificateType) {
                WebRtcEndpoint.Builder builder = new 
WebRtcEndpoint.Builder(pipeline);
+               // See 
https://doc-kurento.readthedocs.io/en/latest/features/security.html#media-plane-security-dtls
+               if (CertificateKeyType.RSA.name().equals(certificateType)) {

Review comment:
       That would mean you need to pass in the entire KHandler into the method ?
   AbstractStream is not a bean. It requires parameters to be passed in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to