solomax commented on a change in pull request #140:
URL: https://github.com/apache/openmeetings/pull/140#discussion_r601029774
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
##########
@@ -48,8 +49,15 @@ public void release() {
public abstract void release(boolean remove);
- public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean recv) {
+ public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean recv,
+ String certificateType) {
WebRtcEndpoint.Builder builder = new
WebRtcEndpoint.Builder(pipeline);
+ // See
https://doc-kurento.readthedocs.io/en/latest/features/security.html#media-plane-security-dtls
+ if (CertificateKeyType.RSA.name().equals(certificateType)) {
Review comment:
yep
this should be
I would do if or switch on passed `CertificateKeyType` here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
