sebawagner commented on a change in pull request #140:
URL: https://github.com/apache/openmeetings/pull/140#discussion_r602618216
##########
File path:
openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/AbstractStream.java
##########
@@ -48,8 +49,15 @@ public void release() {
public abstract void release(boolean remove);
- public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean recv) {
+ public static WebRtcEndpoint createWebRtcEndpoint(MediaPipeline
pipeline, Boolean recv,
Review comment:
That is actually not that easy.
The null value is used as a 3rd option to pass in.
In KTestStream::startTestRecording it passes _explicitly_ null into the
method so that the stream is not marked as **neither** recv nor send only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
