mawiesne commented on code in PR #456:
URL: https://github.com/apache/opennlp/pull/456#discussion_r1048939494
##########
opennlp-tools/src/main/java/opennlp/tools/namefind/TokenNameFinderFactory.java:
##########
@@ -133,18 +173,36 @@ public void validateArtifactMap() throws
InvalidFormatException {
// no additional artifacts
}
+ /**
+ * @return Retrieves a {@link SequenceCodec} instance.
+ */
public SequenceCodec<String> createSequenceCodec() {
if (artifactProvider != null) {
- String sequeceCodecImplName = artifactProvider.getManifestProperty(
+ String sequenceCodecImplName = artifactProvider.getManifestProperty(
TokenNameFinderModel.SEQUENCE_CODEC_CLASS_NAME_PARAMETER);
- return instantiateSequenceCodec(sequeceCodecImplName);
+ try {
+ return instantiateSequenceCodec(sequenceCodecImplName);
+ } catch (InvalidFormatException e) {
+ // TODO Is this compensation valid here? Or: should we escalate
towards the caller?
+ System.out.println("Encountered a problem with the sequence codec '"
Review Comment:
@jzonthemtn I'll remove the sysout here tmrw. The discussion about logger or
not seems a separate issue and/or a discussion for the dev lis, that is: can't
be solved with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]