mawiesne commented on code in PR #456:
URL: https://github.com/apache/opennlp/pull/456#discussion_r1052221134
##########
opennlp-tools/src/main/java/opennlp/tools/namefind/TokenNameFinderModel.java:
##########
@@ -88,37 +117,109 @@ public TokenNameFinderModel(String languageCode,
MaxentModel nameFinderModel, in
}
}
- // TODO: Extend this one with beam size!
- public TokenNameFinderModel(String languageCode, MaxentModel nameFinderModel,
- byte[] generatorDescriptor, Map<String, Object> resources, Map<String,
String> manifestInfoEntries) {
+ /**
+ * Initializes a {@link TokenNameFinderModel} instance via given parameters.
+ *
+ * @param languageCode The ISO conform language code.
+ * @param nameFinderModel A valid {@link MaxentModel}.
+ * @param generatorDescriptor The {@code byte[]} representing the feature
generator descriptor.
+ * @param resources Additional resources in a mapping.
+ * @param manifestInfoEntries Additional information kept in the manifest.
+ *
+ * @throws IllegalArgumentException Thrown if the {@code namFinderModel}
incompatible
+ * with {@code seqCodec}.
+ */
+ public TokenNameFinderModel(String languageCode, MaxentModel
nameFinderModel, byte[] generatorDescriptor,
+ Map<String, Object> resources, Map<String,
String> manifestInfoEntries) {
this(languageCode, nameFinderModel, NameFinderME.DEFAULT_BEAM_SIZE,
- generatorDescriptor, resources, manifestInfoEntries, new BioCodec(),
new TokenNameFinderFactory());
+ generatorDescriptor, resources, manifestInfoEntries,
+ new BioCodec(), new TokenNameFinderFactory());
}
+ /**
+ * Initializes a {@link TokenNameFinderModel} instance via given parameters.
+ *
+ * @param languageCode The ISO conform language code.
+ * @param nameFinderModel A valid {@link MaxentModel}.
+ * @param beamSize The beam size. Must be greater than {@code 0}.
+ * @param generatorDescriptor The {@code byte[]} representing the feature
generator descriptor.
+ * @param resources Additional resources in a mapping.
+ * @param manifestInfoEntries Additional information kept in the manifest.
+ *
+ * @throws IllegalArgumentException Thrown if the {@code namFinderModel}
incompatible
+ * with {@code seqCodec}.
+ */
+ public TokenNameFinderModel(String languageCode, MaxentModel
nameFinderModel, int beamSize,
+ byte[] generatorDescriptor, Map<String, Object>
resources,
+ Map<String, String> manifestInfoEntries) {
+ this(languageCode, nameFinderModel, beamSize,
+ generatorDescriptor, resources, manifestInfoEntries,
+ new BioCodec(), new TokenNameFinderFactory());
+ }
+
+ /**
+ * Initializes a {@link TokenNameFinderModel} instance via given parameters.
+ *
+ * @param languageCode The ISO conform language code.
+ * @param nameFinderModel A valid {@link MaxentModel}.
+ * @param resources Additional resources in a mapping.
+ * @param manifestInfoEntries Additional information kept in the manifest.
+ *
+ * @throws IllegalArgumentException Thrown if the {@code namFinderModel}
incompatible
Review Comment:
Will also fix the missing "is" here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]