mawiesne commented on code in PR #456:
URL: https://github.com/apache/opennlp/pull/456#discussion_r1052225879


##########
opennlp-tools/src/main/java/opennlp/tools/namefind/RegexNameFinder.java:
##########
@@ -178,18 +197,34 @@ public void clearAdaptiveData() {
     // nothing to clear
   }
 
+  /**
+   * @return Retrieves the {@link Pattern patterns} used.
+   */
+  // TODO Unclear what 'm' stands for: Discuss refactoring, deprecation, or 
removal of unused method.
   public Pattern[] getmPatterns() {

Review Comment:
   @kinow @atarora What's your opinion in terms of 
   "refactoring, deprecation, or removal" of this unused method?
   
   Either
   - (A)  refactor it to `getMatchingPatterns()`
   - (B)  refactor it to `getMatchingPatterns()` and deprecate
   - (C) leave method name unchanged and provide an explanation of "m" via 
JavaDoc text
   - (D)  remove without deprecation period



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to