rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1116140811
##########
opennlp-tools/src/main/java/opennlp/tools/formats/masc/MascDocument.java:
##########
@@ -353,7 +353,7 @@ private void addPennTags(Map<String, Map<Integer, ?>>
tagMaps) throws IOExceptio
//Check that all tokens have at least one quark.
for (Map.Entry<Integer, int[]> token : tokenToQuarks.entrySet()) {
if (token.getValue().length == 0) {
- System.err.println("[ERROR] Token without quarks: " +
token.getKey());
+ logger.error("Token without quarks: {}", token.getKey());
Review Comment:
I agree with `warn` here. We can change within
https://issues.apache.org/jira/browse/OPENNLP-1449 (next sub-task, next topic).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]