rzo1 commented on PR #492: URL: https://github.com/apache/opennlp/pull/492#issuecomment-1442313117
> Thanks @rzo1 for those important changes and the work you put in! Great progress! > > I have mostly minor feedback, but found one or two changes that we need to work out or find consensus on. No hard blockers, though. Needs @jzonthemtn and/or feedback by @kinow et al. Thanks for the review. We discussed the importance of the sysouts with a :coffee: a while ago. So I am definitly in favour for **not** removing them. We should maybe replace them with trace and actually comment them in, so we have it in place if needed. Don't think we need to have it as dead code. Regarding the variable substituion / replacement / injection: Will revice and change with https://issues.apache.org/jira/browse/OPENNLP-1450 Regarding log levels: Will revise and change with https://issues.apache.org/jira/browse/OPENNLP-1449 I will resolve the current merge conflict now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
