rzo1 commented on code in PR #492: URL: https://github.com/apache/opennlp/pull/492#discussion_r1116142935
########## opennlp-tools/src/main/java/opennlp/tools/ml/perceptron/PerceptronTrainer.java: ########## @@ -391,7 +394,7 @@ private MutableContext[] findParameters(int iterations, boolean useAverage) { if (StrictMath.abs(prevAccuracy1 - trainingAccuracy) < tolerance && StrictMath.abs(prevAccuracy2 - trainingAccuracy) < tolerance && StrictMath.abs(prevAccuracy3 - trainingAccuracy) < tolerance) { - display("Stopping: change in training set accuracy less than " + tolerance + "\n"); + logger.info("Stopping: change in training set accuracy less than {}", tolerance); Review Comment: Would make sense in this context, yes. Previously was a plain Sys.out We can change with https://issues.apache.org/jira/browse/OPENNLP-1449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org