krickert commented on PR #1151: URL: https://github.com/apache/opennlp/pull/1151#issuecomment-4952773714
Verified: all twelve concrete implementations (the eleven in core plus `SpellCheckingCharSequenceNormalizer` in the spellcheck extension) reject null with `IllegalArgumentException`, so the contract holds uniformly. On the "may return the same instance" sentence: agreed it does not help callers, so I dropped it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
