krickert commented on code in PR #1151:
URL: https://github.com/apache/opennlp/pull/1151#discussion_r3568368845
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/util/normalizer/TwitterCharSequenceNormalizer.java:
##########
@@ -17,262 +17,19 @@
package opennlp.tools.util.normalizer;
/**
- * A {@link CharSequenceNormalizer} implementation that normalizes text
- * in terms of Twitter character patterns. Every encounter will be replaced by
a whitespace.
+ * The former name of {@link SocialMediaCharSequenceNormalizer}, kept so
existing references
+ * keep working.
*
- * <p>Four forward cursor passes reproduce, byte for byte, the output of the
former regex
- * implementation:</p>
- * <ol>
- * <li>a {@code #} or {@code @} followed by at least one non-whitespace
character, together
- * with the whole following non-whitespace run, becomes one space (the
whitespace class is
- * the six ASCII characters the former {@code \S} complemented);</li>
- * <li>each maximal sequence of {@code rt} units (case-insensitive, each
followed by a space or
- * colon) becomes one space when it starts on a word boundary as the JDK
regex engine
- * defined it for {@code \b};</li>
- * <li>each emoticon, eyes {@code :}, {@code ;} or {@code x}, an optional
{@code -} nose, and a
- * mouth out of {@code ( ) d o p} (case-insensitive), becomes one space,
including inside
- * words;</li>
- * <li>laughter, a run of {@code h}/{@code j}, a run of vowels, and at least
one repetition of
- * the two runs' last characters, shrinks to those two characters twice
- * ({@code "hahaha"} to {@code "haha"}), comparing ASCII
case-insensitively.</li>
- * </ol>
+ * @deprecated Use {@link SocialMediaCharSequenceNormalizer}.
Review Comment:
Dropped it entirely in f3a2da4b, which I think is the cleaner of your two
options: since 3.0 is a major version, removing the deprecated alias outright
beats carrying it forward with forRemoval. Nothing references it (the language
detector's context generator does not use it), so removal is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
