krickert commented on PR #1150: URL: https://github.com/apache/opennlp/pull/1150#issuecomment-4960496058
For me +1 delete and tear off the band aid. But the caveat - I don't know the user base enough. I think the compat flag is fine. Removing it is easiest though since we would maintain 2.x for a bit and encourage customers to upgrade.. I tried marking for deprecation but the splash damage is pretty big (but don't mind doing it) - as it'll touch like 20 files. I'm OK with any approach though, mainly because I'm not as familiar with the customer base. Given that @rzo1 and @jzonthemtn have more history and context with the code - I'll yield the decision for the rest of the team instead of making any sort of call. I can quickly change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
