On 6/13/13 3:58 PM, Andre Fischer wrote: > On 13.06.2013 15:53, Andre Fischer wrote: >> Hi, >> >> Arial > > Ariel, sorry. But hey, I got it right the second time below. > >> just found and fixed bug 122518 [1] which is caused by values in XCU >> configuration files that got translated. This would be good for >> values displayed on the UI. However, in this case, the values where >> boolean values that are only used internally. Their values should be >> "true" or "false". Numerical values 0 and 1 might also be OK. The >> Spanish word for "true", "verdadero" is not one of the recognized >> values and its use in the XCU file causes an error that prevents >> OpenOffice from starting. A variant of this bug causes a build >> breaker when building localized installation sets. >> >> This change, replacing "true" by localized values (not restricted to >> Spanish), was caused by revision 1465678 [2] (no issue id was given in >> the log message). This revision has changes in 115 files. Commit >> message was: >> >> removed all non en-US messages incl. x-comment, to enable correct >> translation. >> corrected a few problems where en-US was dublicated. >> NO code/makefile changes >> >> Not only x-comment but also x-no-translate flags where removed. This >> flag tells translators not to translate a string. Removing it, as the >> commit message explains, enables [correct] translations. And it >> caused "true" to be translated into Spanish, and maybe to other >> languages as well. Ariel and Hanya have found this one bug but with >> 115 files changed, more and subtler (ie harder to find) bugs may still >> exist. >> >> Therefore I would like to propose to revert revision 1465678 and >> re-apply it after careful review. I don't want to blame the author of >> this change. Things like this can happen to everybody. I just want to >> be on the save side and prevent bugs that might escape our QA and make >> it into the release.
I tend to agree here, I ran into problems because of this changes as well. I first thought it is build problem only because it worked on Windows and Linux but it wasn't. We can't say for sure what else is affected and I believe it requires some more investigation and of course testing of localized builds. As the acting release manager I support the revert for AOO 4.0 and we should continue to analyze the consequences in more detail. Other opinions? Maybe Jan who integrated the change with of course good intention can share his opinion with us as well. Juergen >> >> Best regards, >> Andre >> >> >> [1] https://issues.apache.org/ooo/show_bug.cgi?id=122518 >> [2] http://svn.apache.org/viewvc?view=revision&revision=1465678 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > For additional commands, e-mail: dev-h...@openoffice.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
