On 14 June 2013 15:02, Andre Fischer <awf....@gmail.com> wrote: > On 14.06.2013 14:40, janI wrote: > >> On 13 June 2013 21:19, Andrea Pescetti <pesce...@apache.org> wrote: >> >> Jürgen Schmidt wrote: >>> >>> On 13.06.2013 15:53, Andre Fischer wrote: >>>> >>>>> This change, replacing "true" by localized values (not restricted to >>>>>> Spanish), was caused by revision 1465678 ... >>>>>> >>>>>> As the acting release manager I support the revert for AOO 4.0 and we >>>>> >>>> should continue to analyze the consequences in more detail. >>>> Other opinions? Maybe Jan who integrated the change with of course good >>>> intention can share his opinion with us as well. >>>> >>>> I remember we discussed it on the lists before Jan committed it, but >>> it is >>> clear we overlooked something. If I understand correctly, this won't >>> break >>> the current localization process (or will it?). >>> >>> The change comes from me, after a discussion on the dev list and was >> applied as agreed. >> > > As I said earlier, I have proposed the revert for reasons of > practicability not for blaming you or anybody else. Reverting it takes > away the pressure to find a fix fast.
I did not read it as blame, I am just embarressed that it happened. At the time, I checked it by compiled with the langauges I use, so maybe it is a combination of my changes and other later changes. But this is analyse we can do afterward. > > > >> BUT never the less, since it is a build breaker, it needs to be reverted. >> I >> know as responsible committer I should do it, but at the moment my svn >> tree >> is not up date, and I will be offline until monday, Can someone please do >> the revert for me, I have all the changes in the l10n branch so just ditch >> the commit. >> >> I am sorry to have caused a build breaker, that was never my intention >> (but >> always my fear). >> > > If this was your first build breaker then I am way ahead of you :-) > > > >> If it has not been reverted monday, then I will do it (as I should). >> > > I was planning on waiting till Monday anyway. It will be soon enough if > you take care of it then. Enjoy the weekend. > I had a couple of spare cycles, and googled how to revert a revision. I thought it was a matter of saying "svn remove -r x", but it seems I have do both merge and revert. To be quite frank, I am afraid to break even more, I will happely do the changes (in spare cycles or monday), but I seriously need someone to help me with the commands, or please do it, and mail the commands in here, so we all can learn. If I understand it correct, I have to "svn merge" all newer commits back to the last commit before my revision, and commit the result, but that sounds as something that can potentially ruin the whole svn tree. have a nice weekend. jan I. > > Regards, > Andre > > > >> rgds >> Jan I. >> >> Ps. the commit is old, so at least it underlines my request from earlier >> that we regulary build languages in buildbot. >> >> >> >> If it doesn't, I support reverting the change and reapplying it, perhaps >>> with the needed changes, immediately after 4.0 is released. >>> >>> Regards, >>> Andrea. >>> >>> >>> ------------------------------****----------------------------** >>> --**--------- >>> To unsubscribe, e-mail: >>> dev-unsubscribe@openoffice.**a**pache.org<http://apache.org> >>> <dev-unsubscribe@**openoffice.apache.org<dev-unsubscr...@openoffice.apache.org> >>> > >>> >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >>> >>> > > ------------------------------**------------------------------**--------- > To unsubscribe, e-mail: > dev-unsubscribe@openoffice.**apache.org<dev-unsubscr...@openoffice.apache.org> > For additional commands, e-mail: dev-h...@openoffice.apache.org > >
