On Thu, May 15, Kay Schenk wrote:

> OK, this is looking interesting, but...please revert this change as the
> next "real" publish is likely to make this live and we probably don't want
> to do this yet without further review.
>
> So, please do the following --
>
> * copy the revised version of brand.mdtext to the /test directory (we
> can then review this further)
> * revert your brand.mdtext change at the top level
>
> Thanks.
>
>
Kay, I reverted /templates/brand.html to revision before my changes
(robweir).
No changes in brand.mdtext, apart from localized site (he), which still
functions.
So, there are no apparent changes in the ooo-site now.

I'm not sure how we're going to test this, since now the feature isn't
online, and I didn't find a way to override the brand.html template within
a localized site, or /test; it's a global template.

Anyway, I've created a branch -
templates/brand-branch-with-language-select.html, so save template changes,
for future testing.
Please help in testing it, in the near future. My tests showed that all
redirections work properly in Chrome. Default-selected language is selected
according to the language defined in brand.mdtext (for example, see
/xx/brand.mdtext or /he/brand.mdtext).

Tal



> On 05/14/2014 01:21 AM, Tal Daniel wrote:
> > On Wed, May 14 I wrote:
> >
> >> Following my suggestion, I've changed the brand.html template to show a
> >> lanaugage selection dropdown on all sites (currently available on
> staging
> >> sites only - http://ooo-site.staging.apache.org/).
> >>
> >
> > To see a working example, select עברית (Hebrew) from the dropdown menu.
>

>

Reply via email to