On 17/05/2014 Tal Daniel wrote:
http://ooo-site.staging.apache.org/test/templates/brand-template-with-language-select-without-vars.html Please test it a bit, comment here, and if all goes well, I'll move the code into the site brand.html template, to affect all sites.
Thanks for this! It looks good enough to me to go live. Please allow a bit more of the usual 72 hours for feedback, since mail delivery seems to be back to normal but we may still experience some delays.
I had already reviewed the select list and code when it was on staging, and it's OK. My accessibility concern was not on the select, but on the JavaScript manipulating it. I also see some alignment issues in the select (it seems that the drop-down is a few pixels taller than it should be), see http://i.imgur.com/inLcLeD.png but this is definitely minor. And in general all these problems can be addressed later.
My main concern is that, even limiting it to the 38 released languages, I see that quite a few localized websites still need an update. This might indeed be an occasion to discuss on the l10n list how to handle this, and what criteria should be met for a site to be listed here. Based on this, I would still include the "Other" item at the end of the select as a link to native-lang.html then go live with the 38 languages and immediately ask the l10n list for volunteers in updating the relevant sites.
Regards, Andrea. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
