On 13/11/2014 Michal Hriň wrote:
I made very simple patch. http://people.apache.org/~hrin/dejavu/
Looks quite correct. The normal way would be to open an issue of type PATCH and attach your patch. Make just one .patch file, obtained with svn diff or git diff. And don't forget to send the link here to connect it to this discussion.
Please review, and feel free to add it to trunk if it will be good. And add comments if I'm doing something wrong.
I didn't test it yet, but I would only double-check that replacing the ZIP file with a tar.gz archive does not require other changes. The rest looks good.
It is a update of external package :)
And here is a problem, but it doesn't depend on you. Policy so far has been: we download build-time dependencies from the Extensions site and from Apache Extras. If Apache Extras (currently part of Google Code) do not allow us to upload files any longer, then this is the first occurrence of a problem that we have largely anticipated but not solved yet. This shouldn't stop us from updating libraries, but for sure we (the entire Apache Foundation, not OpenOffice only) must find a viable replacement before the next release.
Regards, Andrea. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
