Re: Dynamic OpenSSL causes Curl regression on *nix

[Matthias Seidel]

Hi All,

Am 02.05.24 um 14:02 schrieb Matthias Seidel:

Hi Arrigo,

Am 01.05.24 um 20:31 schrieb Arrigo Marchiori:

Hello All,

TL;DR: I think that keeping distinct branches for trunk and AOO42X is
good practice, and we shall work on stabilizing AOO42X. More below.

To be clear, I am not thinking of build or stability problems when I say that we cannot release AOO 4.2.0.

This should be a primary problem to be solved.

Even if all release blockers in AOO42X are fixed, we do not have a working release process! Translations are outdated and we have no way to get them into our code or new strings into our translation process.

Or at least start with a new "Roadmap" for 2024?

Regards,

   Matthias

I would have expected that we start a discussion about improving the release process at this point.

Regards,

   Matthias

On Wed, May 01, 2024 at 03:52:19PM +0200, Matthias Seidel wrote:

Hi Pedro,

Am 01.05.24 um 15:39 schrieb Pedro Lino:

Hi Matthias

On 05/01/2024 1:30 PM WEST Matthias Seidel <matthias.sei...@hamburg.de> wrote:

Maybe it is easier to delete the current 42x branch and start a new 42X

branch? If any patches were added to 42X only (and they are still

relevant), then these should be cherry picked to trunk before splitting...

+1.


trunk as possible.

The AOO42X branch is quite old. Development only really happens on trunk. The best maintained branch is trunk, and any branches should be as close to

Trunk is an unstable branch.

That is the nature of Trunk ;)

Yes! And should not be the nature of AOO42X, IMHO.

Everything we want to have in AOO42X (which was branched from trunk some

years ago) should have been cherry-picked early.

Do you mean that all patches/fixes in 42X are in Trunk also?

Trunk has all patches, AOO42X only those that were cherry-picked from trunk.

I confirm this. I personally made some patch ``backwards'' (first in
another branch, and then cherry-picked into trunk) but it was my
mistake: our best practice shall be as Matthias described above.

Therefore there would not be a problem in deleting the current branch 42X and start a new one? This would make sense because Damjan mentioned that many relevant fixes in trunk are not included in 42X

If he didn't cherry-pick them (for a reason?) they are not included.

...and if no one else did ;-)

I personally cherry-picked the SSL- and curl-related commits because
of some tests I am doing on AOO42X. I think that it makes sense to
cherry-pick also his latest change of 16-bit into 32-bit indices.

Also why is the next release 4.2.x? Haven't we made enough changes for

5.0.x? If not, what should be in 5.0.x?

It is quite hypothetical to discuss about versions we are NOT capable to

release.

It is. But Damjan's question is still valid? What would be the change needed to consider this 5.0? I would say that having a Winx64 would be such a condition. As it is, I still see this as 42X

For AOO 5.0 I would expect at least that we support ODF 1.3.

A Win64 build would be great for AOO 4.5.0.

I personally would see both these improvements good for AOO 4.2.0, but
I think it's only a matter of... marketing and promotion. This topic
is worth another thread.

But again, we are not able to do a release, we should work on that problem

first.

If we are talking about ``technical'' issues, then I agree that AOO42X
is unstable and for this reason it cannot be released.

The next version we CAN release is 4.1.16 (AOO41X).

That is true!

If we become able to do a release for a newer branch (AOO42X), we should

simply release what we have...

Exactly, but including all valid updates that have been added to trunk but not cherry picked to 42X

+1

If they were not cherry-picked I would expect there was a reason for it?

I think that we have to discuss the meaning of the ``valid'' word as
used above by Pedro.

Almost all commits I saw to trunk would be IMHO applicable to
AOO42X. I do not think there is anything so ``revolutionary'' or
``experimental'', that I would rather delay to 4.3.0, 4.5.0, 5.0.0 or
whatever future AOO version.

However, the author of each commit has IMHO the right to the first
opinion about the opportunity of cherry-picking into AOO42X, AOO41X
etc.

_My_ latest commits to trunk were all targeted to AOO42X. If I did not
cherry-pick them is just because... I forgot to. And Matthias,
sometimes, kindly reminded me about them.

Only trunk should be allowed to be blatantly unstable. The reason for
AOO42X also being unstable is because we inherited it this way. This
is what I understood, at least, and I believe we have to fix this.

I hope I could explain myself clearly.

Best regards,

smime.p7s
Description: Kryptografische S/MIME-Signatur