Hi Bjoern,
there was no need for crucifying yourself, server side we are python
only. Actually we have no perl bindings installed.
I think we need to be a bit carefull with pre-commit hooks. Other than
post-commit hooks they do influence the "user experience" of SVN, so
they have to be fast. Well, we've got a very fast server so probably
this is not really a problem.
I somehow don't like tying SCM functionality to commit messages, but
that's may be just me.
And should we enforce policy (like tabs vs spaces etc) via the SCM tool?
Heiner
bjoern michaelsen - Sun Microsystems - Hamburg Germany wrote:
> Hi list,
>
> since we now have subversion, we might as well use the new features it
> provides. I wrote a precommit hook on the weekend that does some
> precommit sanity checks:
> - It rejects commits changing files in a cws and outside of it (thus
> hopefully preventing some accidental commits to a master
> - It checks all *.{cxx|c|hxx|h} files for correct indentation (no tab
> indentation on added/changed lines)
> - Adding a new module has to be properly announced in the commit message
> - Adding a new toplevel dir in a module has to be properly announced in
> the commit message (this hopefully prevents accidental commit of
> output trees)
> - Never allows changes/deleting of tagged versions
>
> I crucified myself to write the hook in perl because I thought it to be
> the preferred language for releng stuff (I would have preferred python
> myself).
>
> All checks can be disabled with adding special strings to the commit
> message.
>
> Im looking forward to comments, ideas and additions. Is it a good idea
> to use such a precommit hook? Whats relengs position on this?
>
> Have Fun,
>
> Björn
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
Jens-Heiner Rechtien
[EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
