Hi all, Jens-Heiner Rechtien wrote:
> Hi Bjoern, > > there was no need for crucifying yourself, server side we are python > only. Actually we have no perl bindings installed. > > I think we need to be a bit carefull with pre-commit hooks. Other than > post-commit hooks they do influence the "user experience" of SVN, so > they have to be fast. Well, we've got a very fast server so probably > this is not really a problem. > > I somehow don't like tying SCM functionality to commit messages, but > that's may be just me. > > And should we enforce policy (like tabs vs spaces etc) via the SCM tool? In the past we used a cvs wrapper in Hamburg to prevent at least one of the things that Björn's hook tries to address (accidental commits to wrong branches). And we just had a case where exactly this happened. I don't think that "fix it later after someone discovered it" is the right way to go here. Then why should we test any CWS before we integrate it? We also always wanted to have a way to prevent mixes of tabs and spaces, we even have a requirement for spaces instead of tabs in our coding guidelines. So why not enforce it when there is a simple way to achieve that? Moreover, the hook solution is even superior to the cvs wrapper as Björn's implementation allows for an override mechanism. And additionally it offers a solution for another problem that we already discovered: the unintentional addition of directories, especially top level directories. I think that both make sense, an intentional adding will happen so rarely that it is bearable to require an additional action. Ciao, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't reply to "[EMAIL PROTECTED]". I use it for the OOo lists and only rarely read other mails sent to it. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
