I'm fine with this moving to branch 1.1. I'm not sure it matters though. Ethan
On Tue, May 10, 2011 at 11:08, Ben Pfaff <[email protected]> wrote: > From: Ethan Jackson <[email protected]> > > It doesn't make sense to create a QoS object without any queues. > Before this patch, OVS would configure the QoS object and as a > result drop all traffic going through the affected interface. With > this patch, OVS will simply clear QoS configuration on the > interface. > > Bug #5583. > --- > vswitchd/bridge.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index f304ac0..e43af3c 100644 > --- a/vswitchd/bridge.c > +++ b/vswitchd/bridge.c > @@ -4632,7 +4632,7 @@ iface_update_carrier(struct iface *iface) > static void > iface_update_qos(struct iface *iface, const struct ovsrec_qos *qos) > { > - if (!qos || qos->type[0] == '\0') { > + if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) { > netdev_set_qos(iface->netdev, NULL, NULL); > } else { > struct iface_delete_queues_cbdata cbdata; > -- > 1.7.4.4 > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
