On Thu, May 12, 2011 at 02:44:10PM -0700, Ethan Jackson wrote: > According to the 802.1ag specification, when a CCM is received > which advertises a misconfigured transmission interval, a fault > should be triggered. This patch goes against the spec by simply > warning when this happens. This is done for several reasons. > > - Faults can cause controllers to make potentially expensive > changes in the network topology. > - Faults can be maliciously triggered by crafting invalid CCMs. > - Reducing the number of places in the code where rmp->fault and > cfm->fault are changed makes the code easier to debug and > reason about.
I think that the change is OK but the comment in the code itself should list at least the first two reasons above, not just the third, which isn't nearly as good as rationale. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
