On Thu, May 12, 2011 at 02:44:11PM -0700, Ethan Jackson wrote: > According to the 802.1ag specification, reception of a CCM from an > unexpected source should trigger a fault. This patch causes the CFM > module to simply warn instead. There are several reasons for this > change outlined below. > > - Faults can cause controllers to make potentially expensive > changes to the network topology. > - Faults can be maliciously triggered by crafting invalid CCMs. > - With this patch, cfm->fault and rmp->fault are only updated in > cfm_run() making the code easier to debug and reason about.
This seems reasonable to me. It might be a good idea to document these design decisions in the code. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
