On Thu, May 12, 2011 at 02:44:12PM -0700, Ethan Jackson wrote: > This makes the code more obviously correct in my opinion. > > This patch also removes timer_enabled_at() along with its only > user.
If the 'recv' member of struct remote_mp is a flag then I'd expect it to have type bool, not long long. Does this change the promptness of fault detection at all? That is, will it wait longer in some cases to detect a fault? While I was looking this over, I noticed what might be a bug or might be just a documentation error. cfm_create() doesn't mention that the caller must call cfm_configure() immediately, but I think that that is necessary because otherwise nothing properly initializes the timer than cfm_run() will check. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
