On Wed, Aug 17, 2011 at 07:01:53PM -0700, Justin Pettit wrote:
> There will be a caller added soon.
Regarding ETHTOOL_GFLAGS and ETHTOOL_SFLAGS, usually I add #ifndef
around definitions for macros that might be defined in system headers.
I guess that it's unlikely that these would be defined differently in
system header, though.
I see missing { } around "return" in netdev_linux_ethtool_set_flag().
Also in netdev_linux_ethtool_set_flag(), I would make 'enable' a bool.
Otherwise I'm happy with this, thank you.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
