On Aug 18, 2011, at 9:28 AM, Ben Pfaff wrote:
> Regarding ETHTOOL_GFLAGS and ETHTOOL_SFLAGS, usually I add #ifndef
> around definitions for macros that might be defined in system headers.
> I guess that it's unlikely that these would be defined differently in
> system header, though.
That's fair. I added them.
> I see missing { } around "return" in netdev_linux_ethtool_set_flag().
Heh. And I was the one who pushed that coding standard in the userspace code.
> Also in netdev_linux_ethtool_set_flag(), I would make 'enable' a bool.
Weird, it was like that at some point--that's why I included stdbool.h in the
header file.
> Otherwise I'm happy with this, thank you.
Thanks. I'll push this once the second patch is reviewed.
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
