On Aug 18, 2011, at 9:22 PM, Jesse Gross wrote: > The main thing that I was wondering about in this patch is the implications > for the backports in RHEL 5. I looked through some of their patches and it > appears that they backported LRO (and drivers that enable it) but not the > userspace interface (I could be wrong about this though). If that's the case > then this will break on that platform because the userspace request to > disable LRO would be ignored. In that situation, we'd probably need to make > the kernel continue to disable LRO on the old kernels. This is still an > improvement though because the userspace/kernel expectations are set properly > and on those old kernels it would just seem like the NIC doesn't support LRO.
How would you propose handling this? Putting a RHEL 5 kernel version guard around a call to dev_disable_lro() in vport-netdev.c? --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev