On Tue, Aug 21, 2012 at 01:55:42PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman <[email protected]>

Passing the "struct netdev_stats" to append_port_stat10() and
append_port_stat11() by value, rather than through a pointer, looks
needlessly inefficient to me (although possibly GCC optimizes this
out).  I'd prefer to use a pointer.

Otherwise this looks good, thank you.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to